Photos: Upload

Does the description disclose side effects, auth requirements, rate limits, or destructive behavior?

Annotations only say write, non-destructive; the description goes well beyond that with a 30s default / 45s max timeout, partial-batch semantics with the untried files list, the local read restriction, and the indexing lag that can hide taken dates and previews. These are exactly the operational facts an agent cannot get from structured fields.

Agents need to know what a tool does to the world before calling it. Descriptions should go beyond structured annotations to explain consequences.

Is the description appropriately sized, front-loaded, and free of redundancy?

Four sentences, purpose first, then access constraint, then timeout/partial-result behavior, then indexing consequence. No filler and each sentence carries a distinct operational fact.

Shorter descriptions cost fewer tokens and are easier for agents to parse. Every sentence should earn its place.

Given the tool's complexity, does the description cover enough for an agent to succeed on first attempt?

For a mutation tool with no output schema and thin annotations, it covers the safety-relevant behavior (local-only reads, timeouts, partial batches) well. The main gap is the response shape, e.g. whether it returns a task identifier or per-file statuses, which the agent must discover at runtime.

Complex tools with many parameters or behaviors need more documentation. Simple tools need less. This dimension scales expectations accordingly.

Does the description clarify parameter syntax, constraints, interactions, or defaults beyond what the schema provides?

Schema description coverage is 100%, so the schema already explains album, space, folder, local_paths and on_duplicate. The description restates the album-optional relationship and the allowed-folder constraint on local_paths but adds no syntax or format detail beyond the schema, so the baseline applies.

Input schemas describe structure but not intent. Descriptions should explain non-obvious parameter relationships and valid value ranges.

Does the description clearly state what the tool does and how it differs from similar tools?

It names a specific verb (upload) plus resource (photos/videos), destination (Synology Photos folder) and the optional album attachment. 'From this machine' implicitly separates it from server-side siblings like copy_photos or move_photos, though no sibling is named explicitly.

Agents choose between tools based on descriptions. A clear purpose with a specific verb and resource helps agents select the right tool.

Does the description explain when to use this tool, when not to, or what alternatives exist?

It gives real operating context: files must live inside allowed local folders, album attachment is optional, and results are truncated by a task timeout with untried files returned for a follow-up call. It never explicitly contrasts with upload_file or copy_photos, so the alternative-selection guidance is inferred rather than stated.

Agents often have multiple tools that could apply. Explicit usage guidance like "use X instead of Y when Z" prevents misuse.