// Copyright 2025 Stefan Prodan.
// SPDX-License-Identifier: AGPL-3.0
package controller
import (
"context"
"fmt"
"os"
"testing"
"time"
"github.com/fluxcd/pkg/apis/meta"
"github.com/fluxcd/pkg/cache"
"github.com/fluxcd/pkg/git/github"
"github.com/fluxcd/pkg/runtime/conditions"
. "github.com/onsi/gomega"
corev1 "k8s.io/api/core/v1"
apierrors "k8s.io/apimachinery/pkg/api/errors"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"sigs.k8s.io/controller-runtime/pkg/client"
"sigs.k8s.io/controller-runtime/pkg/reconcile"
"sigs.k8s.io/yaml"
fluxcdv1 "github.com/controlplaneio-fluxcd/flux-operator/api/v1"
"github.com/controlplaneio-fluxcd/flux-operator/internal/testutils"
)
func TestResourceSetInputProviderReconciler_GitTag_LifeCycle(t *testing.T) {
g := NewWithT(t)
reconciler := getResourceSetInputProviderReconciler(t)
rsetReconciler := getResourceSetReconciler(t)
ctx, cancel := context.WithTimeout(context.Background(), timeout)
defer cancel()
ns, err := testEnv.CreateNamespace(ctx, "test")
g.Expect(err).ToNot(HaveOccurred())
_, githubSecretRef := createGitHubTokenSecret(t, ctx, ns.Name)
objDef := fmt.Sprintf(`
apiVersion: fluxcd.controlplane.io/v1
kind: ResourceSetInputProvider
metadata:
name: test
namespace: "%[1]s"
labels:
app: test
spec:
type: GitLabTag
url: "https://gitlab.com/stefanprodan/podinfo"
filter:
semver: "6.0.x"
limit: 1
`, ns.Name)
setDef := fmt.Sprintf(`
apiVersion: fluxcd.controlplane.io/v1
kind: ResourceSet
metadata:
name: test
namespace: "%[1]s"
spec:
inputsFrom:
- selector:
matchLabels:
app: test
resources:
- apiVersion: v1
kind: ConfigMap
metadata:
name: test-<< inputs.id >>
namespace: << inputs.provider.namespace >>
data:
tag: << inputs.tag | quote >>
sha: << inputs.sha | quote >>
`, ns.Name)
obj := &fluxcdv1.ResourceSetInputProvider{}
err = yaml.Unmarshal([]byte(objDef), obj)
g.Expect(err).ToNot(HaveOccurred())
// Create the ResourceSetInputProvider.
err = testEnv.Create(ctx, obj)
g.Expect(err).ToNot(HaveOccurred())
// Initialize the ResourceSetInputProvider.
r, err := reconciler.Reconcile(ctx, reconcile.Request{
NamespacedName: client.ObjectKeyFromObject(obj),
})
g.Expect(err).ToNot(HaveOccurred())
g.Expect(r.Requeue).To(BeTrue())
// Retrieve the inputs.
r, err = reconciler.Reconcile(ctx, reconcile.Request{
NamespacedName: client.ObjectKeyFromObject(obj),
})
g.Expect(err).ToNot(HaveOccurred())
g.Expect(r.Requeue).To(BeFalse())
// Check if the ResourceSetInputProvider was marked as ready.
result := &fluxcdv1.ResourceSetInputProvider{}
err = testClient.Get(ctx, client.ObjectKeyFromObject(obj), result)
g.Expect(err).ToNot(HaveOccurred())
testutils.LogObjectStatus(t, result)
g.Expect(conditions.GetReason(result, meta.ReadyCondition)).To(BeIdenticalTo(meta.ReconciliationSucceededReason))
g.Expect(result.Status.LastExportedRevision).To(BeIdenticalTo("sha256:e3ac49c7196218482dc476d8d91d192fa3244cea4233f9a06b7154848d162f6e"))
// Create a ResourceSet referencing the ResourceSetInputProvider.
rset := &fluxcdv1.ResourceSet{}
err = yaml.Unmarshal([]byte(setDef), rset)
g.Expect(err).ToNot(HaveOccurred())
err = testEnv.Create(ctx, rset)
g.Expect(err).ToNot(HaveOccurred())
// Initialize the ResourceSet.
_, err = rsetReconciler.Reconcile(ctx, reconcile.Request{
NamespacedName: client.ObjectKeyFromObject(rset),
})
g.Expect(err).ToNot(HaveOccurred())
// Reconcile the ResourceSet.
_, err = rsetReconciler.Reconcile(ctx, reconcile.Request{
NamespacedName: client.ObjectKeyFromObject(rset),
})
g.Expect(err).ToNot(HaveOccurred())
// Check if the ResourceSet generated the GitLab ConfigMap.
resultGitLab := &corev1.ConfigMap{
ObjectMeta: metav1.ObjectMeta{
Name: "test-48955639",
Namespace: ns.Name,
},
}
err = testClient.Get(ctx, client.ObjectKeyFromObject(resultGitLab), resultGitLab)
g.Expect(err).ToNot(HaveOccurred())
g.Expect(resultGitLab.Data).To(HaveKeyWithValue("tag", "6.0.4"))
g.Expect(resultGitLab.Data).To(HaveKeyWithValue("sha", "11cf36d83818e64aaa60d523ab6438258ebb6009"))
// Update the input and switch to GitHub.
resultP := result.DeepCopy()
resultP.Spec.Type = fluxcdv1.InputProviderGitHubTag
resultP.Spec.URL = "https://github.com/stefanprodan/podinfo"
resultP.Spec.Filter.Semver = "5.0.x"
resultP.Spec.SecretRef = githubSecretRef
err = testClient.Patch(ctx, resultP, client.MergeFrom(result))
g.Expect(err).ToNot(HaveOccurred())
r, err = reconciler.Reconcile(ctx, reconcile.Request{
NamespacedName: client.ObjectKeyFromObject(obj),
})
g.Expect(err).ToNot(HaveOccurred())
// Check if the exported inputs were updated.
resultFinal := &fluxcdv1.ResourceSetInputProvider{}
err = testClient.Get(ctx, client.ObjectKeyFromObject(obj), resultFinal)
g.Expect(err).ToNot(HaveOccurred())
testutils.LogObjectStatus(t, resultFinal)
g.Expect(conditions.GetReason(result, meta.ReadyCondition)).To(BeIdenticalTo(meta.ReconciliationSucceededReason))
g.Expect(resultFinal.Status.LastExportedRevision).To(BeIdenticalTo("sha256:b38e157576a4d77008d01a8aee077b118b8b1346dd0f8aa58ae7680b190b8b96"))
// Reconcile the ResourceSet.
_, err = rsetReconciler.Reconcile(ctx, reconcile.Request{
NamespacedName: client.ObjectKeyFromObject(rset),
})
g.Expect(err).ToNot(HaveOccurred())
// Check if the GitHub ConfigMap was created.
resultGitHub := &corev1.ConfigMap{
ObjectMeta: metav1.ObjectMeta{
Name: "test-48562421",
Namespace: ns.Name,
},
}
err = testClient.Get(ctx, client.ObjectKeyFromObject(resultGitHub), resultGitHub)
g.Expect(err).ToNot(HaveOccurred())
g.Expect(resultGitHub.Data).To(HaveKeyWithValue("tag", "5.0.3"))
g.Expect(resultGitHub.Data).To(HaveKeyWithValue("sha", "95be17be1dc2103eb5e2c0b0bac50ef692c4657d"))
// Check if the GitLab ConfigMap was deleted.
err = testClient.Get(ctx, client.ObjectKeyFromObject(resultGitLab), resultGitLab)
g.Expect(err).To(HaveOccurred())
g.Expect(apierrors.IsNotFound(err)).To(BeTrue())
// Delete the ResourceSetInputProvider.
err = testClient.Delete(ctx, obj)
g.Expect(err).ToNot(HaveOccurred())
r, err = reconciler.Reconcile(ctx, reconcile.Request{
NamespacedName: client.ObjectKeyFromObject(obj),
})
g.Expect(err).ToNot(HaveOccurred())
g.Expect(r.IsZero()).To(BeTrue())
// Check if the ResourceSetInputProvider was finalized.
result = &fluxcdv1.ResourceSetInputProvider{}
err = testClient.Get(ctx, client.ObjectKeyFromObject(obj), result)
g.Expect(err).To(HaveOccurred())
g.Expect(apierrors.IsNotFound(err)).To(BeTrue())
// Reconcile the ResourceSet with no providers.
_, err = rsetReconciler.Reconcile(ctx, reconcile.Request{
NamespacedName: client.ObjectKeyFromObject(rset),
})
g.Expect(err).ToNot(HaveOccurred())
// Check if the GitHub ConfigMap was deleted.
err = testClient.Get(ctx, client.ObjectKeyFromObject(resultGitHub), resultGitHub)
g.Expect(err).To(HaveOccurred())
g.Expect(apierrors.IsNotFound(err)).To(BeTrue())
// Delete the ResourceSet.
err = testClient.Delete(ctx, rset)
g.Expect(err).ToNot(HaveOccurred())
r, err = rsetReconciler.Reconcile(ctx, reconcile.Request{
NamespacedName: client.ObjectKeyFromObject(rset),
})
g.Expect(err).ToNot(HaveOccurred())
g.Expect(r.IsZero()).To(BeTrue())
}
func TestResourceSetInputProviderReconciler_GitLabBranch_LifeCycle(t *testing.T) {
g := NewWithT(t)
reconciler := getResourceSetInputProviderReconciler(t)
rsetReconciler := getResourceSetReconciler(t)
ctx, cancel := context.WithTimeout(context.Background(), timeout)
defer cancel()
ns, err := testEnv.CreateNamespace(ctx, "test")
g.Expect(err).ToNot(HaveOccurred())
objDef := fmt.Sprintf(`
apiVersion: fluxcd.controlplane.io/v1
kind: ResourceSetInputProvider
metadata:
name: test
namespace: "%[1]s"
spec:
type: GitLabBranch
url: "https://gitlab.com/stefanprodan/podinfo"
filter:
includeBranch: "^patch-[1|2]$"
`, ns.Name)
setDef := fmt.Sprintf(`
apiVersion: fluxcd.controlplane.io/v1
kind: ResourceSet
metadata:
name: test
namespace: "%[1]s"
spec:
inputsFrom:
- name: test
resources:
- apiVersion: v1
kind: ConfigMap
metadata:
name: test-<< inputs.id >>
namespace: << inputs.provider.namespace >>
data:
branch: << inputs.branch | quote >>
sha: << inputs.sha | quote >>
`, ns.Name)
obj := &fluxcdv1.ResourceSetInputProvider{}
err = yaml.Unmarshal([]byte(objDef), obj)
g.Expect(err).ToNot(HaveOccurred())
// Create the ResourceSetInputProvider.
err = testEnv.Create(ctx, obj)
g.Expect(err).ToNot(HaveOccurred())
// Initialize the ResourceSetInputProvider.
r, err := reconciler.Reconcile(ctx, reconcile.Request{
NamespacedName: client.ObjectKeyFromObject(obj),
})
g.Expect(err).ToNot(HaveOccurred())
g.Expect(r.Requeue).To(BeTrue())
// Retrieve the inputs.
r, err = reconciler.Reconcile(ctx, reconcile.Request{
NamespacedName: client.ObjectKeyFromObject(obj),
})
g.Expect(err).ToNot(HaveOccurred())
g.Expect(r.Requeue).To(BeFalse())
// Check if the ResourceSetInputProvider was marked as ready.
result := &fluxcdv1.ResourceSetInputProvider{}
err = testClient.Get(ctx, client.ObjectKeyFromObject(obj), result)
g.Expect(err).ToNot(HaveOccurred())
testutils.LogObjectStatus(t, result)
g.Expect(conditions.GetReason(result, meta.ReadyCondition)).To(BeIdenticalTo(meta.ReconciliationSucceededReason))
g.Expect(result.Status.LastExportedRevision).To(BeIdenticalTo("sha256:be31afc5e49da21b12fdca6a2cad6916cad26f4bbde8c16e5822359f75c1d46a"))
// Create a ResourceSet referencing the ResourceSetInputProvider.
rset := &fluxcdv1.ResourceSet{}
err = yaml.Unmarshal([]byte(setDef), rset)
g.Expect(err).ToNot(HaveOccurred())
err = testEnv.Create(ctx, rset)
g.Expect(err).ToNot(HaveOccurred())
// Initialize the ResourceSet instance.
_, err = rsetReconciler.Reconcile(ctx, reconcile.Request{
NamespacedName: client.ObjectKeyFromObject(rset),
})
g.Expect(err).ToNot(HaveOccurred())
// Reconcile the ResourceSet instance.
_, err = rsetReconciler.Reconcile(ctx, reconcile.Request{
NamespacedName: client.ObjectKeyFromObject(rset),
})
g.Expect(err).ToNot(HaveOccurred())
// Check if the ResourceSet generated the resources.
result1CM := &corev1.ConfigMap{
ObjectMeta: metav1.ObjectMeta{
Name: "test-183501423",
Namespace: ns.Name,
},
}
err = testClient.Get(ctx, client.ObjectKeyFromObject(result1CM), result1CM)
g.Expect(err).ToNot(HaveOccurred())
g.Expect(result1CM.Data).To(HaveKeyWithValue("branch", "patch-1"))
g.Expect(result1CM.Data).To(HaveKeyWithValue("sha", "cebef2d870bc83b37f43c470bae205fca094bacc"))
result2CM := &corev1.ConfigMap{
ObjectMeta: metav1.ObjectMeta{
Name: "test-183566960",
Namespace: ns.Name,
},
}
err = testClient.Get(ctx, client.ObjectKeyFromObject(result2CM), result2CM)
g.Expect(err).ToNot(HaveOccurred())
g.Expect(result2CM.Data).To(HaveKeyWithValue("branch", "patch-2"))
g.Expect(result2CM.Data).To(HaveKeyWithValue("sha", "a275fb0322466eaa1a74485a4f79f88d7c8858e8"))
// Update the filter to exclude all results.
resultP := result.DeepCopy()
resultP.Spec.Filter.ExcludeBranch = "^patch-.*$"
err = testClient.Patch(ctx, resultP, client.MergeFrom(result))
g.Expect(err).ToNot(HaveOccurred())
r, err = reconciler.Reconcile(ctx, reconcile.Request{
NamespacedName: client.ObjectKeyFromObject(obj),
})
g.Expect(err).ToNot(HaveOccurred())
// Check if the exported inputs were updated.
resultFinal := &fluxcdv1.ResourceSetInputProvider{}
err = testClient.Get(ctx, client.ObjectKeyFromObject(obj), resultFinal)
g.Expect(err).ToNot(HaveOccurred())
g.Expect(resultFinal.Status.ExportedInputs).To(BeEmpty())
g.Expect(resultFinal.Status.LastExportedRevision).To(BeIdenticalTo("sha256:38e0b9de817f645c4bec37c0d4a3e58baecccb040f5718dc069a72c7385a0bed"))
// Reconcile the ResourceSet to remove the generated resources.
_, err = rsetReconciler.Reconcile(ctx, reconcile.Request{
NamespacedName: client.ObjectKeyFromObject(rset),
})
g.Expect(err).ToNot(HaveOccurred())
// Check if the generated resources were removed.
err = testClient.Get(ctx, client.ObjectKeyFromObject(result1CM), result1CM)
g.Expect(err).To(HaveOccurred())
g.Expect(apierrors.IsNotFound(err)).To(BeTrue())
err = testClient.Get(ctx, client.ObjectKeyFromObject(result2CM), result2CM)
g.Expect(err).To(HaveOccurred())
g.Expect(apierrors.IsNotFound(err)).To(BeTrue())
// Delete the ResourceSetInputProvider.
err = testClient.Delete(ctx, obj)
g.Expect(err).ToNot(HaveOccurred())
r, err = reconciler.Reconcile(ctx, reconcile.Request{
NamespacedName: client.ObjectKeyFromObject(obj),
})
g.Expect(err).ToNot(HaveOccurred())
g.Expect(r.IsZero()).To(BeTrue())
// Check if the ResourceSetInputProvider was finalized.
result = &fluxcdv1.ResourceSetInputProvider{}
err = testClient.Get(ctx, client.ObjectKeyFromObject(obj), result)
g.Expect(err).To(HaveOccurred())
g.Expect(apierrors.IsNotFound(err)).To(BeTrue())
// Delete the ResourceSet.
err = testClient.Delete(ctx, rset)
g.Expect(err).ToNot(HaveOccurred())
r, err = rsetReconciler.Reconcile(ctx, reconcile.Request{
NamespacedName: client.ObjectKeyFromObject(rset),
})
g.Expect(err).ToNot(HaveOccurred())
g.Expect(r.IsZero()).To(BeTrue())
}
func TestResourceSetInputProviderReconciler_GitHubPullRequest_LifeCycle(t *testing.T) {
g := NewWithT(t)
reconciler := getResourceSetInputProviderReconciler(t)
rsetReconciler := getResourceSetReconciler(t)
ctx, cancel := context.WithTimeout(context.Background(), timeout)
defer cancel()
ns, err := testEnv.CreateNamespace(ctx, "test")
g.Expect(err).ToNot(HaveOccurred())
githubSecretRef, _ := createGitHubTokenSecret(t, ctx, ns.Name)
objDef := fmt.Sprintf(`
apiVersion: fluxcd.controlplane.io/v1
kind: ResourceSetInputProvider
metadata:
name: test
namespace: "%[1]s"
spec:
type: GitHubPullRequest
url: "https://github.com/fluxcd-testing/pr-testing"
%[2]s
defaultValues:
env: "staging"
filter:
limit: 2
includeBranch: "^stefanprodan-patch-.*$"
labels:
- "enhancement"
`, ns.Name, githubSecretRef)
exportedInputs := `
- author: stefanprodan
branch: stefanprodan-patch-4
env: staging
id: "4"
sha: 80332195632fe293564ff563344032cf4c75af45
title: 'test4: Update README.md'
labels:
- documentation
- enhancement
- author: stefanprodan
branch: stefanprodan-patch-2
env: staging
id: "2"
sha: 1e5aef14d38a8c67e5240308adf2935d6cdc2ec8
title: 'test2: Update README.md'
labels:
- enhancement
`
setDef := fmt.Sprintf(`
apiVersion: fluxcd.controlplane.io/v1
kind: ResourceSet
metadata:
name: test
namespace: "%[1]s"
spec:
inputsFrom:
- name: test
resources:
- apiVersion: v1
kind: ConfigMap
metadata:
name: test-<< inputs.id >>
namespace: << inputs.provider.namespace >>
data:
branch: << inputs.branch | quote >>
sha: << inputs.sha | quote >>
title: << inputs.title | quote >>
author: << inputs.author | quote >>
env: << inputs.env | quote >>
labels: << inputs.labels | join "," >>
`, ns.Name)
obj := &fluxcdv1.ResourceSetInputProvider{}
err = yaml.Unmarshal([]byte(objDef), obj)
g.Expect(err).ToNot(HaveOccurred())
// Initialize the ResourceSetInputProvider.
err = testEnv.Create(ctx, obj)
g.Expect(err).ToNot(HaveOccurred())
r, err := reconciler.Reconcile(ctx, reconcile.Request{
NamespacedName: client.ObjectKeyFromObject(obj),
})
g.Expect(err).ToNot(HaveOccurred())
g.Expect(r.Requeue).To(BeTrue())
// Check if the finalizer was added.
resultInit := &fluxcdv1.ResourceSetInputProvider{}
err = testClient.Get(ctx, client.ObjectKeyFromObject(obj), resultInit)
g.Expect(err).ToNot(HaveOccurred())
testutils.LogObjectStatus(t, resultInit)
g.Expect(resultInit.Finalizers).To(ContainElement(fluxcdv1.Finalizer))
r, err = reconciler.Reconcile(ctx, reconcile.Request{
NamespacedName: client.ObjectKeyFromObject(obj),
})
g.Expect(err).ToNot(HaveOccurred())
g.Expect(r.Requeue).To(BeFalse())
// Check if the ResourceSetInputProvider was marked as ready.
result := &fluxcdv1.ResourceSetInputProvider{}
err = testClient.Get(ctx, client.ObjectKeyFromObject(obj), result)
g.Expect(err).ToNot(HaveOccurred())
testutils.LogObjectStatus(t, result)
g.Expect(conditions.GetReason(result, meta.ReadyCondition)).To(BeIdenticalTo(meta.ReconciliationSucceededReason))
// Check if the exported inputs are correct.
inputsData, err := yaml.Marshal(result.Status.ExportedInputs)
g.Expect(err).ToNot(HaveOccurred())
g.Expect(string(inputsData)).To(MatchYAML(exportedInputs))
// Create a ResourceSet referencing the ResourceSetInputProvider.
rset := &fluxcdv1.ResourceSet{}
err = yaml.Unmarshal([]byte(setDef), rset)
g.Expect(err).ToNot(HaveOccurred())
err = testEnv.Create(ctx, rset)
g.Expect(err).ToNot(HaveOccurred())
// Initialize the ResourceSet instance.
_, err = rsetReconciler.Reconcile(ctx, reconcile.Request{
NamespacedName: client.ObjectKeyFromObject(rset),
})
g.Expect(err).ToNot(HaveOccurred())
// Reconcile the ResourceSet instance.
_, err = rsetReconciler.Reconcile(ctx, reconcile.Request{
NamespacedName: client.ObjectKeyFromObject(rset),
})
g.Expect(err).ToNot(HaveOccurred())
// Check if the ResourceSet generated the resources.
resultCM := &corev1.ConfigMap{
ObjectMeta: metav1.ObjectMeta{
Name: "test-2",
Namespace: ns.Name,
},
}
err = testClient.Get(ctx, client.ObjectKeyFromObject(resultCM), resultCM)
g.Expect(err).ToNot(HaveOccurred())
g.Expect(resultCM.Data).To(HaveKeyWithValue("branch", "stefanprodan-patch-2"))
g.Expect(resultCM.Data).To(HaveKeyWithValue("sha", "1e5aef14d38a8c67e5240308adf2935d6cdc2ec8"))
g.Expect(resultCM.Data).To(HaveKeyWithValue("title", "test2: Update README.md"))
g.Expect(resultCM.Data).To(HaveKeyWithValue("author", "stefanprodan"))
g.Expect(resultCM.Data).To(HaveKeyWithValue("env", "staging"))
g.Expect(resultCM.Data).To(HaveKeyWithValue("labels", "enhancement"))
// Update the filter to exclude all results.
resultP := result.DeepCopy()
resultP.Spec.Filter.ExcludeBranch = "^stefanprodan-.*$"
err = testClient.Patch(ctx, resultP, client.MergeFrom(result))
g.Expect(err).ToNot(HaveOccurred())
r, err = reconciler.Reconcile(ctx, reconcile.Request{
NamespacedName: client.ObjectKeyFromObject(obj),
})
g.Expect(err).ToNot(HaveOccurred())
// Check if the exported inputs were updated.
resultFinal := &fluxcdv1.ResourceSetInputProvider{}
err = testClient.Get(ctx, client.ObjectKeyFromObject(obj), resultFinal)
g.Expect(err).ToNot(HaveOccurred())
g.Expect(resultFinal.Status.ExportedInputs).To(BeEmpty())
// Reconcile the ResourceSet to remove the generated resources.
_, err = rsetReconciler.Reconcile(ctx, reconcile.Request{
NamespacedName: client.ObjectKeyFromObject(rset),
})
g.Expect(err).ToNot(HaveOccurred())
// Check if the generated resources were removed.
err = testClient.Get(ctx, client.ObjectKeyFromObject(resultCM), resultCM)
g.Expect(err).To(HaveOccurred())
g.Expect(apierrors.IsNotFound(err)).To(BeTrue())
// Delete the ResourceSetInputProvider.
err = testClient.Delete(ctx, obj)
g.Expect(err).ToNot(HaveOccurred())
r, err = reconciler.Reconcile(ctx, reconcile.Request{
NamespacedName: client.ObjectKeyFromObject(obj),
})
g.Expect(err).ToNot(HaveOccurred())
g.Expect(r.IsZero()).To(BeTrue())
// Check if the ResourceSetInputProvider was finalized.
result = &fluxcdv1.ResourceSetInputProvider{}
err = testClient.Get(ctx, client.ObjectKeyFromObject(obj), result)
g.Expect(err).To(HaveOccurred())
g.Expect(apierrors.IsNotFound(err)).To(BeTrue())
// Reconcile the ResourceSet and expect a provider not found error.
_, err = rsetReconciler.Reconcile(ctx, reconcile.Request{
NamespacedName: client.ObjectKeyFromObject(rset),
})
g.Expect(err).To(HaveOccurred())
g.Expect(apierrors.IsNotFound(err)).To(BeTrue())
// Delete the ResourceSet.
err = testClient.Delete(ctx, rset)
g.Expect(err).ToNot(HaveOccurred())
r, err = rsetReconciler.Reconcile(ctx, reconcile.Request{
NamespacedName: client.ObjectKeyFromObject(rset),
})
g.Expect(err).ToNot(HaveOccurred())
g.Expect(r.IsZero()).To(BeTrue())
}
func TestResourceSetInputProviderReconciler_FailureRecovery(t *testing.T) {
g := NewWithT(t)
reconciler := getResourceSetInputProviderReconciler(t)
ctx, cancel := context.WithTimeout(context.Background(), timeout)
defer cancel()
ns, err := testEnv.CreateNamespace(ctx, "test")
g.Expect(err).ToNot(HaveOccurred())
objDef := fmt.Sprintf(`
apiVersion: fluxcd.controlplane.io/v1
kind: ResourceSetInputProvider
metadata:
name: test-failure-recovery
namespace: "%[1]s"
spec:
type: GitLabBranch
url: "https://gitlab.com/stefanprodan/podinfo-not-found"
filter:
includeBranch: "^patch-[1|2]$"
`, ns.Name)
obj := &fluxcdv1.ResourceSetInputProvider{}
err = yaml.Unmarshal([]byte(objDef), obj)
g.Expect(err).ToNot(HaveOccurred())
// Create the ResourceSetInputProvider.
err = testEnv.Create(ctx, obj)
g.Expect(err).ToNot(HaveOccurred())
// Initialize the ResourceSetInputProvider.
r, err := reconciler.Reconcile(ctx, reconcile.Request{
NamespacedName: client.ObjectKeyFromObject(obj),
})
g.Expect(err).ToNot(HaveOccurred())
g.Expect(r.Requeue).To(BeTrue())
// Try to reconcile the inputs with upstream.
r, err = reconciler.Reconcile(ctx, reconcile.Request{
NamespacedName: client.ObjectKeyFromObject(obj),
})
g.Expect(err).To(HaveOccurred())
// Check if the ResourceSetInputProvider was marked as failed.
result := &fluxcdv1.ResourceSetInputProvider{}
err = testClient.Get(ctx, client.ObjectKeyFromObject(obj), result)
g.Expect(err).ToNot(HaveOccurred())
g.Expect(conditions.IsReady(result)).To(BeFalse())
g.Expect(conditions.GetReason(result, meta.ReadyCondition)).To(BeIdenticalTo(meta.ReconciliationFailedReason))
g.Expect(conditions.GetMessage(result, meta.ReadyCondition)).To(ContainSubstring("404 Not Found"))
g.Expect(result.Status.ExportedInputs).To(BeEmpty())
// Check if the failure event was recorded.
events := getEvents(result.Name, result.Namespace)
g.Expect(events[0].Reason).To(Equal(meta.ReconciliationFailedReason))
g.Expect(events[0].Message).To(ContainSubstring("failed to list branches"))
// Update the URL to a valid repository.
resultP := result.DeepCopy()
resultP.Spec.URL = "https://gitlab.com/stefanprodan/podinfo"
err = testClient.Patch(ctx, resultP, client.MergeFrom(result))
g.Expect(err).ToNot(HaveOccurred())
// Reconcile the inputs with upstream.
r, err = reconciler.Reconcile(ctx, reconcile.Request{
NamespacedName: client.ObjectKeyFromObject(obj),
})
g.Expect(err).ToNot(HaveOccurred())
// Check if the exported inputs were updated and marked as ready.
resultFinal := &fluxcdv1.ResourceSetInputProvider{}
err = testClient.Get(ctx, client.ObjectKeyFromObject(obj), resultFinal)
g.Expect(err).ToNot(HaveOccurred())
g.Expect(conditions.IsReady(resultFinal)).To(BeTrue())
g.Expect(resultFinal.Status.ExportedInputs).ToNot(BeEmpty())
g.Expect(resultFinal.Status.LastExportedRevision).To(BeIdenticalTo("sha256:be31afc5e49da21b12fdca6a2cad6916cad26f4bbde8c16e5822359f75c1d46a"))
// Delete the ResourceSetInputProvider.
err = testClient.Delete(ctx, obj)
g.Expect(err).ToNot(HaveOccurred())
r, err = reconciler.Reconcile(ctx, reconcile.Request{
NamespacedName: client.ObjectKeyFromObject(obj),
})
g.Expect(err).ToNot(HaveOccurred())
g.Expect(r.IsZero()).To(BeTrue())
// Check if the ResourceSetInputProvider was finalized.
result = &fluxcdv1.ResourceSetInputProvider{}
err = testClient.Get(ctx, client.ObjectKeyFromObject(obj), result)
g.Expect(err).To(HaveOccurred())
g.Expect(apierrors.IsNotFound(err)).To(BeTrue())
}
func TestResourceSetInputProviderReconciler_getGitHubToken_cached(t *testing.T) {
const key = "dd2ce27f135e666c946a3bd4657f4ffaf1d2c97d9a35b93336f467dcdd93a56b"
g := NewWithT(t)
ctx := context.Background()
tokenCache, err := cache.NewTokenCache(1)
g.Expect(err).NotTo(HaveOccurred())
r := &ResourceSetInputProviderReconciler{
TokenCache: tokenCache,
}
_, _, err = r.TokenCache.GetOrSet(ctx, key, func(context.Context) (cache.Token, error) {
return &github.AppToken{
Token: "my-gh-app-token",
ExpiresAt: time.Now().Add(time.Hour),
}, nil
})
g.Expect(err).NotTo(HaveOccurred())
privateKeyPEM, err := os.ReadFile("testdata/rsa-private-key.pem")
g.Expect(err).NotTo(HaveOccurred())
token, err := r.getGitHubToken(ctx, &fluxcdv1.ResourceSetInputProvider{}, map[string][]byte{
"githubAppID": []byte("123"),
"githubAppInstallationID": []byte("123456"),
"githubAppBaseURL": []byte("https://github.com"),
"githubAppPrivateKey": privateKeyPEM,
}, nil)
g.Expect(err).NotTo(HaveOccurred())
g.Expect(token).To(Equal("my-gh-app-token"))
}
func TestResourceSetInputProviderReconciler_SkipExportedInputsUpdate_LifeCycle(t *testing.T) {
defaultStatus := `
conditions:
- lastTransitionTime: "2025-03-28T09:53:36Z"
message: Reconciliation finished in 331ms
observedGeneration: 1
reason: ReconciliationSucceeded
status: "True"
type: Ready
exportedInputs:
- author: stefanprodan
branch: stefanprodan-patch-4
env: staging
id: "4"
sha: 342db2d64746fedf3a8768d351621b7fda2362f3
title: 'test4: Update README.md'
labels:
- documentation
- enhancement
- test
- author: stefanprodan
branch: stefanprodan-patch-2
env: staging
id: "2"
sha: 381635adf7bfa06e48cb958531cc1d44e03a744c
title: 'test2: Update README.md'
labels:
- enhancement
`
objDef := `
apiVersion: fluxcd.controlplane.io/v1
kind: ResourceSetInputProvider
metadata:
name: test
namespace: %[1]s
spec:
type: GitHubPullRequest
url: "https://github.com/fluxcd-testing/pr-testing"
%[3]s
defaultValues:
env: "staging"
filter:
includeBranch: "^stefanprodan-patch-.*$"
labels:
- "enhancement"
skip:
labels:
%[2]s
`
tests := []struct {
name string
skipDef string
statusDef string // fake status to simulate previous exported inputs
expectedInputs string
}{
{
name: "Skip label",
skipDef: `- "documentation"`,
statusDef: defaultStatus,
expectedInputs: `
- author: stefanprodan
branch: stefanprodan-patch-4
env: staging
id: "4"
sha: 342db2d64746fedf3a8768d351621b7fda2362f3
title: 'test4: Update README.md'
labels:
- documentation
- enhancement
- test
- author: stefanprodan
branch: stefanprodan-patch-2
env: staging
id: "2"
sha: 1e5aef14d38a8c67e5240308adf2935d6cdc2ec8
title: 'test2: Update README.md'
labels:
- enhancement
- author: stefanprodan
branch: stefanprodan-patch-1
env: staging
id: "1"
sha: 2dd3a8d2088457e5cf991018edf13e25cbd61380
title: 'test1: Update README.md'
labels:
- enhancement
`,
},
{
name: "Skip label with reverse",
skipDef: `- "!documentation"`,
statusDef: defaultStatus,
expectedInputs: `
- author: stefanprodan
branch: stefanprodan-patch-4
env: staging
id: "4"
sha: 80332195632fe293564ff563344032cf4c75af45
title: 'test4: Update README.md'
labels:
- documentation
- enhancement
- author: stefanprodan
branch: stefanprodan-patch-2
env: staging
id: "2"
sha: 381635adf7bfa06e48cb958531cc1d44e03a744c
title: 'test2: Update README.md'
labels:
- enhancement
`,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
g := NewWithT(t)
reconciler := getResourceSetInputProviderReconciler(t)
ctx, cancel := context.WithTimeout(context.Background(), timeout)
defer cancel()
ns, err := testEnv.CreateNamespace(ctx, "test")
g.Expect(err).ToNot(HaveOccurred())
githubSecretRef, _ := createGitHubTokenSecret(t, ctx, ns.Name)
objDef := fmt.Sprintf(objDef, ns.Name, tt.skipDef, githubSecretRef)
obj := &fluxcdv1.ResourceSetInputProvider{}
err = yaml.Unmarshal([]byte(objDef), obj)
g.Expect(err).ToNot(HaveOccurred())
// Initialize the ResourceSetInputProvider.
err = testEnv.Create(ctx, obj)
g.Expect(err).ToNot(HaveOccurred())
err = yaml.Unmarshal([]byte(tt.statusDef), &obj.Status)
g.Expect(err).ToNot(HaveOccurred())
// Manually update the exportedInputs to simulate previous exportedInputs
err = testEnv.Status().Update(ctx, obj)
g.Expect(err).ToNot(HaveOccurred())
r, err := reconciler.Reconcile(ctx, reconcile.Request{
NamespacedName: client.ObjectKeyFromObject(obj),
})
g.Expect(err).ToNot(HaveOccurred())
g.Expect(r.Requeue).To(BeTrue())
r, err = reconciler.Reconcile(ctx, reconcile.Request{
NamespacedName: client.ObjectKeyFromObject(obj),
})
g.Expect(err).ToNot(HaveOccurred())
g.Expect(r.Requeue).To(BeFalse())
// Check if the ResourceSetInputProvider was marked as ready.
result := &fluxcdv1.ResourceSetInputProvider{}
err = testClient.Get(ctx, client.ObjectKeyFromObject(obj), result)
g.Expect(err).ToNot(HaveOccurred())
testutils.LogObjectStatus(t, result)
// Check if the exported inputs are correct.
inputsData, err := yaml.Marshal(result.Status.ExportedInputs)
g.Expect(err).ToNot(HaveOccurred())
g.Expect(string(inputsData)).To(MatchYAML(tt.expectedInputs))
})
}
}
func TestResourceSetInputProviderReconciler_InvalidGitURL(t *testing.T) {
g := NewWithT(t)
ctx, cancel := context.WithTimeout(context.Background(), timeout)
defer cancel()
ns, err := testEnv.CreateNamespace(ctx, "test-invalid-git-url")
g.Expect(err).ToNot(HaveOccurred())
for _, tt := range []struct {
provider string
}{
{provider: fluxcdv1.InputProviderGitHubBranch},
{provider: fluxcdv1.InputProviderGitHubTag},
{provider: fluxcdv1.InputProviderGitHubPullRequest},
{provider: fluxcdv1.InputProviderGitLabBranch},
{provider: fluxcdv1.InputProviderGitLabTag},
{provider: fluxcdv1.InputProviderGitLabMergeRequest},
{provider: fluxcdv1.InputProviderAzureDevOpsBranch},
{provider: fluxcdv1.InputProviderAzureDevOpsPullRequest},
{provider: fluxcdv1.InputProviderAzureDevOpsTag},
} {
t.Run(tt.provider, func(t *testing.T) {
g := NewWithT(t)
obj := &fluxcdv1.ResourceSetInputProvider{
ObjectMeta: metav1.ObjectMeta{
Name: "test",
Namespace: ns.Name,
},
Spec: fluxcdv1.ResourceSetInputProviderSpec{
Type: tt.provider,
URL: "github.com/stefanprodan/podinfo",
},
}
err = testEnv.Create(ctx, obj)
g.Expect(err).To(HaveOccurred())
g.Expect(err.Error()).To(ContainSubstring(
"spec.url must start with 'http://' or 'https://' when spec.type is a Git provider"))
})
}
}
func TestResouceSetInputProviderReconciler_getAzureDevOpsToken(t *testing.T) {
r := getResourceSetInputProviderReconciler(t)
ctx, cancel := context.WithTimeout(context.Background(), timeout)
defer cancel()
t.Run("with basic auth", func(t *testing.T) {
g := NewWithT(t)
res, err := r.getAzureDevOpsToken(ctx, nil, map[string][]byte{
"username": []byte("user"),
"password": []byte("pass"),
})
g.Expect(err).NotTo(HaveOccurred())
g.Expect(res).To(Equal("pass"))
})
t.Run("with workload identity", func(t *testing.T) {
g := NewWithT(t)
ctx, cancel := context.WithTimeout(context.Background(), time.Second)
defer cancel()
res, err := r.getAzureDevOpsToken(ctx, &fluxcdv1.ResourceSetInputProvider{}, nil)
g.Expect(err).To(HaveOccurred())
g.Expect(err.Error()).To(ContainSubstring("ManagedIdentityCredential"))
g.Expect(res).To(BeEmpty())
})
}
func createGitHubTokenSecret(t *testing.T, ctx context.Context, ns string) (string, *meta.LocalObjectReference) {
g := NewWithT(t)
token := os.Getenv("GITHUB_TOKEN")
if token == "" {
return "", nil
}
secret := &corev1.Secret{
ObjectMeta: metav1.ObjectMeta{
Name: "github-token",
Namespace: ns,
},
StringData: map[string]string{
"username": "github-token",
"password": token,
},
}
g.Expect(testClient.Create(ctx, secret)).To(Succeed())
return " secretRef:\n name: github-token\n", &meta.LocalObjectReference{
Name: "github-token",
}
}
