Skip to main content
Glama
Puppet Master
by khr898

puppet_check

Runs allow-listed checks like tests or lint and returns only failures, optionally against a staged patch in an isolated worktree to verify changes.

Instructions

Run an allow-listed check (names from puppet-master.toml, e.g. 'test', 'lint') and get only the failures. With patch_id, runs against that staged patch in an isolated worktree.

Tool call template

Replace each placeholder with a value matching the input schema. Only required parameters are included; add optional parameters as needed.

{
  "id": 1,
  "jsonrpc": "2.0",
  "method": "tools/call",
  "params": {
    "arguments": {
      "cmd": "<cmd>",
      "root": "<root>"
    },
    "name": "puppet_check"
  }
}

Input Schema

NameRequiredDescriptionDefault
cmdYes
rootYes
patch_idNo

Schema Changelog

Changes observed during successful MCP inspections.

  1. First observedv0.1.0

TDQS

A3.7/5.0
Behavior4/5

Does the description disclose side effects, auth requirements, rate limits, or destructive behavior?

With no annotations the description carries the burden, and it does disclose meaningful traits: the command must be allow-listed (invalid names will be rejected), output is filtered to failures only, and patch runs happen in an isolated worktree so the main tree is not mutated. It omits what happens on a non-allow-listed cmd and how failures are formatted.

Agents need to know what a tool does to the world before calling it. Descriptions should go beyond structured annotations to explain consequences.

Conciseness5/5

Is the description appropriately sized, front-loaded, and free of redundancy?

Two tight sentences with zero filler; the allow-list constraint is front-loaded and the patch_id behavior follows in the natural order of use.

Shorter descriptions cost fewer tokens and are easier for agents to parse. Every sentence should earn its place.

Completeness3/5

Given the tool's complexity, does the description cover enough for an agent to succeed on first attempt?

For a tool with no annotations, no output schema, and three undocumented-in-schema parameters, the description should also cover the required 'root' argument and what a 'failures' response looks like. It covers the interesting half but leaves real gaps for an agent calling it correctly on the first try.

Complex tools with many parameters or behaviors need more documentation. Simple tools need less. This dimension scales expectations accordingly.

Parameters3/5

Does the description clarify parameter syntax, constraints, interactions, or defaults beyond what the schema provides?

Schema description coverage is 0%, so the description must compensate. It explains cmd well (allow-listed names from puppet-master.toml, with examples 'test' and 'lint') and patch_id (a staged patch, run in an isolated worktree), but the required 'root' parameter is never mentioned at all.

Input schemas describe structure but not intent. Descriptions should explain non-obvious parameter relationships and valid value ranges.

Purpose4/5

Does the description clearly state what the tool does and how it differs from similar tools?

The description gives a specific verb ('Run') and resource ('allow-listed check') plus a concrete return contract ('get only the failures'), which clearly separates it from puppet_apply/puppet_write/puppet_read siblings. It does not name a sibling it is explicitly not, which keeps it just short of a 5.

Agents choose between tools based on descriptions. A clear purpose with a specific verb and resource helps agents select the right tool.

Usage Guidelines3/5

Does the description explain when to use this tool, when not to, or what alternatives exist?

It implies usage by stating that check names must come from puppet-master.toml and that supplying patch_id targets a staged patch, but it never says when to choose puppet_check over puppet_apply or puppet_status, nor any exclusions.

Agents often have multiple tools that could apply. Explicit usage guidance like "use X instead of Y when Z" prevents misuse.