ofw_upload_expense_pdf

Does the description disclose side effects, auth requirements, rate limits, or destructive behavior?

Goes well beyond the annotations (readOnlyHint=false, destructiveHint=true, openWorldHint=true) by disclosing the side effect that matters most: the file is visible to the co-parent in My Files immediately, independent of the later expense's visibility. It also details the two-phase confirmToken fallback and that phase 1 performs no write. It does not cover limits such as max file size or failure/overwrite behavior.

Agents need to know what a tool does to the world before calling it. Descriptions should go beyond structured annotations to explain consequences.

Is the description appropriately sized, front-loaded, and free of redundancy?

Front-loaded with purpose and the path/url constraint, then the side-effect warning and confirmation mechanics. Dense and mostly waste-free, though the confirmation paragraph is long enough that the key 'no write without confirmation' point competes with procedural detail.

Shorter descriptions cost fewer tokens and are easier for agents to parse. Every sentence should earn its place.

Given the tool's complexity, does the description cover enough for an agent to succeed on first attempt?

Covers the input contract, the mutually-exclusive requirement, the shared-metadata side effect, and the confirmation protocol, and mentions the returned fileId even though no output schema exists. Gaps remain around error cases, size limits, and the full shape of the preview response.

Complex tools with many parameters or behaviors need more documentation. Simple tools need less. This dimension scales expectations accordingly.

Does the description clarify parameter syntax, constraints, interactions, or defaults beyond what the schema provides?

Schema coverage is 100%, so per-parameter meaning is already documented, but the description adds the cross-field rule the schema only implies ('exactly one of path or url'), plus the sequencing constraint on confirmToken (never on first call, never invented, never reused). That is genuine semantics beyond the per-property text.

Input schemas describe structure but not intent. Descriptions should explain non-obvious parameter relationships and valid value ranges.

Does the description clearly state what the tool does and how it differs from similar tools?

States a specific verb + resource + destination: 'Upload a PDF to OurFamilyWizard My Files for later attachment to an expense.' It also implicitly distinguishes itself from the generic sibling ofw_upload_attachment by naming the expense-attachment purpose and the SHARED My Files target.

Agents choose between tools based on descriptions. A clear purpose with a specific verb and resource helps agents select the right tool.

Does the description explain when to use this tool, when not to, or what alternatives exist?

Explicit conditions: exactly one of path or url must be supplied, PDF files only, confirmation is required before any write, and it routes visibility decisions to ofw_create_expense's privateExpense flag. An agent knows when and how to call this versus ofw_upload_attachment.

Agents often have multiple tools that could apply. Explicit usage guidance like "use X instead of Y when Z" prevents misuse.