provider_save

Does the description disclose side effects, auth requirements, rate limits, or destructive behavior?

Annotations only supply readOnlyHint=false, so the description carries most of the burden. It adds real behavioral value: API keys are encrypted locally and never returned, and the call also exercises the model catalog (an outbound side effect). It still omits whether the catalog test can fail the save, and permission/auth requirements.

Agents need to know what a tool does to the world before calling it. Descriptions should go beyond structured annotations to explain consequences.

Is the description appropriately sized, front-loaded, and free of redundancy?

Two compact sentences, front-loaded with the primary action and followed immediately by the security-relevant caveat. No filler or repetition of the tool name.

Shorter descriptions cost fewer tokens and are easier for agents to parse. Every sentence should earn its place.

Given the tool's complexity, does the description cover enough for an agent to succeed on first attempt?

No output schema exists, yet the description does not say what a successful save returns (provider id, catalog test results), and with 0% schema coverage the parameter-level behavior is thin. The encryption disclosure is a meaningful addition, but the definition is only narrowly sufficient for a 7-parameter mutation tool.

Complex tools with many parameters or behaviors need more documentation. Simple tools need less. This dimension scales expectations accordingly.

Does the description clarify parameter syntax, constraints, interactions, or defaults beyond what the schema provides?

Schema description coverage is 0% across 7 parameters, so the description must compensate and largely does not. Only 'apiKey' is indirectly referenced via the encryption sentence; the meaning of id (create vs update switch), adapter, authType, headerName, and baseUrl is left entirely to the enum/type names.

Input schemas describe structure but not intent. Descriptions should explain non-obvious parameter relationships and valid value ranges.

Does the description clearly state what the tool does and how it differs from similar tools?

States a specific verb pair and resource ('Create/update a provider profile') plus a secondary action ('test its model catalog'), so the upsert semantics are clear. It does not distinguish itself from close siblings like provider_refresh or provider_probe, which also touch provider model catalogs.

Agents choose between tools based on descriptions. A clear purpose with a specific verb and resource helps agents select the right tool.

Does the description explain when to use this tool, when not to, or what alternatives exist?

There is no statement of when to choose this over provider_refresh, provider_probe, or provider_model_override, and no prerequisites or exclusions are given. The only implied guidance is the 'create/update' phrasing, which the reader must infer means upsert behavior.

Agents often have multiple tools that could apply. Explicit usage guidance like "use X instead of Y when Z" prevents misuse.