#!/usr/bin/env bash
# Validation helpers for project structure and metadata.
set -euo pipefail
# Validate icons array format per MCP spec.
# Icons must be objects with 'src' property, not plain strings.
# Usage: mcp_validate_icons <json_tool_bin> <meta_path>
# Returns: "ok" if valid/missing, error message if invalid
mcp_validate_icons() {
local json_tool_bin="$1"
local meta_path="$2"
# Check if icons field exists
local has_icons
has_icons="$("${json_tool_bin}" -r 'if has("icons") then "yes" else "no" end' "${meta_path}" 2>/dev/null || printf 'no')"
if [ "${has_icons}" = "no" ]; then
printf 'ok'
return 0
fi
# Check if icons is an array
local icons_type
icons_type="$("${json_tool_bin}" -r '.icons | type' "${meta_path}" 2>/dev/null || printf 'unknown')"
if [ "${icons_type}" != "array" ]; then
printf 'icons must be an array, got %s' "${icons_type}"
return 0
fi
# Check if icons array is empty (valid)
local icons_len
icons_len="$("${json_tool_bin}" -r '.icons | length' "${meta_path}" 2>/dev/null || printf '0')"
if [ "${icons_len}" = "0" ]; then
printf 'ok'
return 0
fi
# Check that all icons are objects with 'src' property
local icons_valid
icons_valid="$("${json_tool_bin}" -r '
.icons |
if length == 0 then true
else all(type == "object" and has("src"))
end
' "${meta_path}" 2>/dev/null || printf 'false')"
if [ "${icons_valid}" = "true" ]; then
printf 'ok'
else
# Find which icons are invalid for better error message
local bad_indices
bad_indices="$("${json_tool_bin}" -r '
[.icons | to_entries[] | select(.value | (type != "object") or (has("src") | not)) | .key] | join(", ")
' "${meta_path}" 2>/dev/null || printf '?')"
printf 'icons[%s] must be objects with "src" property (e.g., {"src": "./icon.svg"})' "${bad_indices}"
fi
}
mcp_validate_server_meta() {
local json_tool_available="$1"
local errors=0
local warnings=0
local server_meta="${MCPBASH_SERVER_DIR}/server.meta.json"
if [ -f "${server_meta}" ]; then
if [ "${json_tool_available}" = "true" ]; then
if ! "${MCPBASH_JSON_TOOL_BIN}" -e '.' "${server_meta}" >/dev/null 2>&1; then
printf '✗ server.d/server.meta.json - invalid JSON\n'
errors=$((errors + 1))
else
local srv_name
srv_name="$("${MCPBASH_JSON_TOOL_BIN}" -r '.name // ""' "${server_meta}" 2>/dev/null || printf '')"
if [ -z "${srv_name}" ]; then
printf '✗ server.d/server.meta.json - missing required "name" field\n'
errors=$((errors + 1))
fi
# Validate icons format
local icons_result
icons_result="$(mcp_validate_icons "${MCPBASH_JSON_TOOL_BIN}" "${server_meta}")"
if [ "${icons_result}" != "ok" ]; then
printf '✗ server.d/server.meta.json - %s\n' "${icons_result}"
errors=$((errors + 1))
fi
if [ -n "${srv_name}" ] && [ "${icons_result}" = "ok" ]; then
printf '✓ server.d/server.meta.json - valid\n'
fi
fi
else
printf '⚠ server.d/server.meta.json - skipped JSON validation (no jq/gojq)\n'
warnings=$((warnings + 1))
fi
else
printf '⚠ server.d/server.meta.json - missing (using smart defaults)\n'
warnings=$((warnings + 1))
fi
printf '%s %s\n' "${errors}" "${warnings}"
}
mcp_validate_tools() {
local tools_root="$1"
local json_tool_available="$2"
local fix="$3"
local errors=0
local warnings=0
local fixes=0
if [ -d "${tools_root}" ]; then
while IFS= read -r -d '' tool_dir; do
case "${tool_dir}" in
*$'\n'* | *$'\r'*)
printf '✗ tools: unsupported directory name (newline/CR)\n'
errors=$((errors + 1))
continue
;;
esac
[ -d "${tool_dir}" ] || continue
local tool_name
tool_name="$(basename "${tool_dir}")"
local meta_path="${tool_dir}/tool.meta.json"
local script_path="${tool_dir}/tool.sh"
local rel_meta="tools/${tool_name}/tool.meta.json"
local rel_script="tools/${tool_name}/tool.sh"
if [ -f "${meta_path}" ]; then
if [ "${json_tool_available}" = "true" ]; then
if ! "${MCPBASH_JSON_TOOL_BIN}" -e '.' "${meta_path}" >/dev/null 2>&1; then
printf '✗ %s - invalid JSON\n' "${rel_meta}"
errors=$((errors + 1))
else
local t_name t_desc has_schema
t_name="$("${MCPBASH_JSON_TOOL_BIN}" -r '.name // ""' "${meta_path}" 2>/dev/null || printf '')"
t_desc="$("${MCPBASH_JSON_TOOL_BIN}" -r '.description // ""' "${meta_path}" 2>/dev/null || printf '')"
has_schema="$("${MCPBASH_JSON_TOOL_BIN}" -r 'if (.inputSchema? // .arguments? // {}) | (has("type") or has("properties")) then "yes" else "" end' "${meta_path}" 2>/dev/null || printf '')"
if [ -z "${t_name}" ]; then
printf '✗ %s - missing required "name"\n' "${rel_meta}"
errors=$((errors + 1))
fi
if [ -z "${t_desc}" ]; then
printf '⚠ %s - missing "description"\n' "${rel_meta}"
warnings=$((warnings + 1))
fi
if [ -z "${has_schema}" ]; then
printf '⚠ %s - inputSchema has no "type" or "properties"\n' "${rel_meta}"
warnings=$((warnings + 1))
fi
# Validate icons format
local icons_result
icons_result="$(mcp_validate_icons "${MCPBASH_JSON_TOOL_BIN}" "${meta_path}")"
if [ "${icons_result}" != "ok" ]; then
printf '✗ %s - %s\n' "${rel_meta}" "${icons_result}"
errors=$((errors + 1))
fi
if [ -n "${t_name}" ]; then
if [[ "${t_name}" != *"-"* && "${t_name}" != *"_"* && "${t_name}" != *"."* ]]; then
printf '⚠ %s - namespace recommended (prefix tool name, e.g., myproj-hello)\n' "${rel_meta}"
warnings=$((warnings + 1))
fi
local name_ok="true"
if [[ ! "${t_name}" =~ ^[A-Za-z0-9_-]{1,64}$ ]]; then
printf '⚠ %s - tool name must match ^[a-zA-Z0-9_-]{1,64}$ (Some clients including Claude Desktop reject dots)\n' "${rel_meta}"
warnings=$((warnings + 1))
name_ok="false"
fi
if [ "${name_ok}" = "true" ] && [ "${icons_result}" = "ok" ]; then
printf '✓ %s - valid\n' "${rel_meta}"
fi
fi
if [ -n "${t_name}" ] && [ "${t_name}" != "${tool_name}" ]; then
# Allow namespace.camelCase names to coexist with kebab-case dirs.
# Strip server prefix (hyphen-delimited) or dot-delimited namespace,
# then normalize (lowercase + remove non-alnum) for kebab↔camel comparison.
local t_stripped t_norm dir_norm
t_stripped="${t_name}"
# 1. Strip hyphen-prefixed server namespace (e.g., "git-hex-cherryPick" → "cherryPick")
if [ -n "${MCPBASH_SERVER_NAME:-}" ] && [ "${MCPBASH_SERVER_NAME}" != "${MCPBASH_SERVER_NAME%-}" ]; then
# Server name shouldn't end with hyphen; normalize it
local srv_prefix="${MCPBASH_SERVER_NAME%-}-"
else
local srv_prefix="${MCPBASH_SERVER_NAME:-}-"
fi
if [ -n "${MCPBASH_SERVER_NAME:-}" ] && [[ "${t_stripped}" == "${srv_prefix}"* ]]; then
t_stripped="${t_stripped#"${srv_prefix}"}"
fi
# 2. Strip dot-prefixed namespace (e.g., "example.hello" → "hello")
t_stripped="${t_stripped##*.}"
# 3. Normalize: lowercase + remove non-alphanumeric (handles kebab↔camel)
t_norm="$(printf '%s' "${t_stripped}" | tr '[:upper:]' '[:lower:]' | tr -cd '[:alnum:]')"
dir_norm="$(printf '%s' "${tool_name}" | tr '[:upper:]' '[:lower:]' | tr -cd '[:alnum:]')"
if [ "${t_norm}" != "${dir_norm}" ]; then
printf '⚠ tools/%s - directory name does not match tool.meta.json name "%s"\n' "${tool_name}" "${t_name}"
warnings=$((warnings + 1))
fi
fi
fi
else
printf '⚠ %s - skipped JSON validation (no jq/gojq)\n' "${rel_meta}"
warnings=$((warnings + 1))
fi
else
printf '✗ %s - missing\n' "${rel_meta}"
errors=$((errors + 1))
fi
if [ -f "${script_path}" ]; then
if [ -x "${script_path}" ]; then
printf '✓ %s - executable\n' "${rel_script}"
else
if [ "${fix}" = "true" ]; then
if [ -L "${script_path}" ]; then
printf '⚠ %s - not executable (symlink; skipped auto-fix, please inspect target)\n' "${rel_script}"
warnings=$((warnings + 1))
elif chmod +x "${script_path}"; then
printf '✓ %s - fixed: made executable\n' "${rel_script}"
fixes=$((fixes + 1))
else
printf '✗ %s - not executable (chmod failed)\n' "${rel_script}"
errors=$((errors + 1))
fi
else
printf '✗ %s - not executable\n' "${rel_script}"
errors=$((errors + 1))
fi
fi
local first_line
first_line="$(head -n 1 "${script_path}" 2>/dev/null || printf '')"
case "${first_line}" in
'#!'*) ;;
*)
printf '⚠ %s - missing shebang\n' "${rel_script}"
warnings=$((warnings + 1))
;;
esac
else
printf '✗ %s - missing\n' "${rel_script}"
errors=$((errors + 1))
fi
done < <(find "${tools_root}" -mindepth 1 -maxdepth 1 -type d -print0 2>/dev/null)
fi
printf '%s %s %s\n' "${errors}" "${warnings}" "${fixes}"
}
mcp_validate_prompts() {
local prompts_root="$1"
local json_tool_available="$2"
local fix="$3"
local errors=0
local warnings=0
local fixes=0
if [ -d "${prompts_root}" ]; then
while IFS= read -r -d '' prompt_dir; do
case "${prompt_dir}" in
*$'\n'* | *$'\r'*)
printf '✗ prompts: unsupported directory name (newline/CR)\n'
errors=$((errors + 1))
continue
;;
esac
[ -d "${prompt_dir}" ] || continue
local prompt_name
prompt_name="$(basename "${prompt_dir}")"
local meta_path="${prompt_dir}/${prompt_name}.meta.json"
local txt_path="${prompt_dir}/${prompt_name}.txt"
local sh_path="${prompt_dir}/${prompt_name}.sh"
local rel_meta="prompts/${prompt_name}/${prompt_name}.meta.json"
if [ -f "${meta_path}" ]; then
if [ "${json_tool_available}" = "true" ]; then
if ! "${MCPBASH_JSON_TOOL_BIN}" -e '.' "${meta_path}" >/dev/null 2>&1; then
printf '✗ %s - invalid JSON\n' "${rel_meta}"
errors=$((errors + 1))
else
local p_name p_desc
p_name="$("${MCPBASH_JSON_TOOL_BIN}" -r '.name // ""' "${meta_path}" 2>/dev/null || printf '')"
p_desc="$("${MCPBASH_JSON_TOOL_BIN}" -r '.description // ""' "${meta_path}" 2>/dev/null || printf '')"
if [ -z "${p_name}" ]; then
printf '✗ %s - missing required "name"\n' "${rel_meta}"
errors=$((errors + 1))
fi
if [ -z "${p_desc}" ]; then
printf '⚠ %s - missing "description"\n' "${rel_meta}"
warnings=$((warnings + 1))
fi
# Validate icons format
local icons_result
icons_result="$(mcp_validate_icons "${MCPBASH_JSON_TOOL_BIN}" "${meta_path}")"
if [ "${icons_result}" != "ok" ]; then
printf '✗ %s - %s\n' "${rel_meta}" "${icons_result}"
errors=$((errors + 1))
fi
if [ -n "${p_name}" ] && [ "${icons_result}" = "ok" ]; then
printf '✓ %s - valid\n' "${rel_meta}"
fi
fi
else
printf '⚠ %s - skipped JSON validation (no jq/gojq)\n' "${rel_meta}"
warnings=$((warnings + 1))
fi
else
printf '✗ %s - missing\n' "${rel_meta}"
errors=$((errors + 1))
fi
if [ ! -f "${txt_path}" ] && [ ! -f "${sh_path}" ]; then
printf '✗ prompts/%s - missing prompt.txt or prompt.sh\n' "${prompt_name}"
errors=$((errors + 1))
fi
if [ -f "${sh_path}" ]; then
if [ -x "${sh_path}" ]; then
printf '✓ prompts/%s/%s.sh - executable\n' "${prompt_name}" "${prompt_name}"
else
if [ "${fix}" = "true" ]; then
if [ -L "${sh_path}" ]; then
printf '⚠ prompts/%s/%s.sh - not executable (symlink; skipped auto-fix, please inspect target)\n' "${prompt_name}" "${prompt_name}"
warnings=$((warnings + 1))
elif chmod +x "${sh_path}"; then
printf '✓ prompts/%s/%s.sh - fixed: made executable\n' "${prompt_name}" "${prompt_name}"
fixes=$((fixes + 1))
else
printf '✗ prompts/%s/%s.sh - not executable (chmod failed)\n' "${prompt_name}" "${prompt_name}"
errors=$((errors + 1))
fi
else
printf '✗ prompts/%s/%s.sh - not executable\n' "${prompt_name}" "${prompt_name}"
errors=$((errors + 1))
fi
fi
fi
done < <(find "${prompts_root}" -mindepth 1 -maxdepth 1 -type d -print0 2>/dev/null)
fi
printf '%s %s %s\n' "${errors}" "${warnings}" "${fixes}"
}
mcp_validate_resources() {
local resources_root="$1"
local json_tool_available="$2"
local fix="$3"
local errors=0
local warnings=0
local fixes=0
if [ -d "${resources_root}" ]; then
while IFS= read -r -d '' res_dir; do
case "${res_dir}" in
*$'\n'* | *$'\r'*)
printf '✗ resources: unsupported directory name (newline/CR)\n'
errors=$((errors + 1))
continue
;;
esac
[ -d "${res_dir}" ] || continue
local res_name
res_name="$(basename "${res_dir}")"
local meta_path="${res_dir}/${res_name}.meta.json"
local sh_path="${res_dir}/${res_name}.sh"
local rel_meta="resources/${res_name}/${res_name}.meta.json"
if [ -f "${meta_path}" ]; then
if [ "${json_tool_available}" = "true" ]; then
if ! "${MCPBASH_JSON_TOOL_BIN}" -e '.' "${meta_path}" >/dev/null 2>&1; then
printf '✗ %s - invalid JSON\n' "${rel_meta}"
errors=$((errors + 1))
else
local r_name r_uri r_uri_template
r_name="$("${MCPBASH_JSON_TOOL_BIN}" -r '.name // ""' "${meta_path}" 2>/dev/null || printf '')"
r_uri="$("${MCPBASH_JSON_TOOL_BIN}" -r '.uri // ""' "${meta_path}" 2>/dev/null || printf '')"
r_uri_template="$("${MCPBASH_JSON_TOOL_BIN}" -r '.uriTemplate // ""' "${meta_path}" 2>/dev/null || printf '')"
if [ -z "${r_name}" ]; then
printf '✗ %s - missing required "name"\n' "${rel_meta}"
errors=$((errors + 1))
fi
# uri and uriTemplate are mutually exclusive per MCP spec
local uri_valid="false"
if [ -n "${r_uri}" ] && [ -n "${r_uri_template}" ]; then
printf '⚠ %s - uri and uriTemplate are mutually exclusive\n' "${rel_meta}"
warnings=$((warnings + 1))
uri_valid="true" # Allow validation to pass with warning
elif [ -z "${r_uri}" ] && [ -z "${r_uri_template}" ]; then
printf '✗ %s - missing required "uri" or "uriTemplate"\n' "${rel_meta}"
errors=$((errors + 1))
elif [ -n "${r_uri}" ]; then
case "${r_uri}" in
*://*) uri_valid="true" ;;
*)
printf '⚠ %s - uri does not look like scheme://...\n' "${rel_meta}"
warnings=$((warnings + 1))
uri_valid="true"
;;
esac
else
# Validate uriTemplate has at least one {variable}
case "${r_uri_template}" in
*"{"*"}"*)
case "${r_uri_template}" in
*://*) uri_valid="true" ;;
*)
printf '⚠ %s - uriTemplate does not look like scheme://...\n' "${rel_meta}"
warnings=$((warnings + 1))
uri_valid="true"
;;
esac
;;
*)
printf '✗ %s - uriTemplate must contain {variable} placeholder\n' "${rel_meta}"
errors=$((errors + 1))
;;
esac
fi
# Validate icons format
local icons_result
icons_result="$(mcp_validate_icons "${MCPBASH_JSON_TOOL_BIN}" "${meta_path}")"
if [ "${icons_result}" != "ok" ]; then
printf '✗ %s - %s\n' "${rel_meta}" "${icons_result}"
errors=$((errors + 1))
fi
if [ -n "${r_name}" ] && [ "${uri_valid}" = "true" ] && [ "${icons_result}" = "ok" ]; then
printf '✓ %s - valid\n' "${rel_meta}"
fi
fi
else
printf '⚠ %s - skipped JSON validation (no jq/gojq)\n' "${rel_meta}"
warnings=$((warnings + 1))
fi
else
printf '✗ %s - missing\n' "${rel_meta}"
errors=$((errors + 1))
fi
if [ -f "${sh_path}" ]; then
if [ -x "${sh_path}" ]; then
printf '✓ resources/%s/%s.sh - executable\n' "${res_name}" "${res_name}"
else
if [ "${fix}" = "true" ]; then
if [ -L "${sh_path}" ]; then
printf '⚠ resources/%s/%s.sh - not executable (symlink; skipped auto-fix, please inspect target)\n' "${res_name}" "${res_name}"
warnings=$((warnings + 1))
elif chmod +x "${sh_path}"; then
printf '✓ resources/%s/%s.sh - fixed: made executable\n' "${res_name}" "${res_name}"
fixes=$((fixes + 1))
else
printf '✗ resources/%s/%s.sh - not executable (chmod failed)\n' "${res_name}" "${res_name}"
errors=$((errors + 1))
fi
else
printf '✗ resources/%s/%s.sh - not executable\n' "${res_name}" "${res_name}"
errors=$((errors + 1))
fi
fi
fi
done < <(find "${resources_root}" -mindepth 1 -maxdepth 1 -type d -print0 2>/dev/null)
fi
printf '%s %s %s\n' "${errors}" "${warnings}" "${fixes}"
}
