M.I.M.I.R - Multi-agent Intelligent Memory & Insight Repository

package cypher import ( "strings" "testing" ) // ============================================================================= // DELETE Query Routing Tests // ============================================================================= // These tests ensure DELETE queries are routed to executeDelete, not executeMatch. // Bug history: DELETE was incorrectly going to executeMatch because: // 1. Old code checked for " DELETE " (with trailing space) but DELETE is often // followed by variable name (e.g., "DELETE n" not "DELETE ") // 2. Relationship deletion wasn't being detected properly in executeDelete // ============================================================================= // TestDeleteRouting_SimpleNode tests basic node deletion routing func TestDeleteRouting_SimpleNode(t *testing.T) { query := "MATCH (n:Person) DELETE n" hasDelete := findKeywordIndex(query, "DELETE") > 0 if !hasDelete { t.Errorf("DELETE routing failed for query: %s", query) } } // TestDeleteRouting_WithProperty tests deletion with property filter containing "Delete" func TestDeleteRouting_WithProperty(t *testing.T) { // The word 'ToDelete' is inside a string literal and should be ignored query := "MATCH (n:Temp {name: 'ToDelete'}) DELETE n" deleteIdx := findKeywordIndex(query, "DELETE") // DELETE should be found OUTSIDE the string literal (after position 30) if deleteIdx <= 30 { t.Errorf("DELETE keyword found inside string literal at index %d, should be > 30", deleteIdx) } // Verify routing check passes hasDelete := deleteIdx > 0 if !hasDelete { t.Errorf("DELETE routing failed for query: %s", query) } } // TestDeleteRouting_Relationship tests relationship deletion routing func TestDeleteRouting_Relationship(t *testing.T) { query := "MATCH ()-[r:KNOWS]->() DELETE r" hasDelete := findKeywordIndex(query, "DELETE") > 0 if !hasDelete { t.Errorf("DELETE routing failed for relationship query: %s", query) } } // TestDeleteRouting_DetachDelete tests DETACH DELETE routing func TestDeleteRouting_DetachDelete(t *testing.T) { query := "MATCH (n:Person) DETACH DELETE n" hasDetachDelete := containsKeywordOutsideStrings(query, "DETACH DELETE") if !hasDetachDelete { t.Errorf("DETACH DELETE routing failed for query: %s", query) } } // TestDeleteRouting_MultipleVariables tests deletion of multiple variables func TestDeleteRouting_MultipleVariables(t *testing.T) { query := "MATCH (a)-[r]->(b) DELETE a, r, b" hasDelete := findKeywordIndex(query, "DELETE") > 0 if !hasDelete { t.Errorf("DELETE routing failed for multi-variable query: %s", query) } } // TestDeleteRouting_WithWhere tests DELETE with WHERE clause func TestDeleteRouting_WithWhere(t *testing.T) { query := "MATCH (n:Person) WHERE n.age > 100 DELETE n" hasDelete := findKeywordIndex(query, "DELETE") > 0 if !hasDelete { t.Errorf("DELETE routing failed for WHERE clause query: %s", query) } } // TestDeleteRouting_NotConfusedByStringContent ensures DELETE inside strings is ignored func TestDeleteRouting_NotConfusedByStringContent(t *testing.T) { testCases := []struct { name string query string }{ {"action property", "MATCH (n {action: 'DELETE'}) DELETE n"}, {"delete in name", "MATCH (n {name: 'DeleteMe'}) DELETE n"}, {"delete substring", "MATCH (n:ToDelete) DELETE n"}, } for _, tc := range testCases { t.Run(tc.name, func(t *testing.T) { // The DELETE keyword for the actual delete operation should be found // OUTSIDE any string literals deleteIdx := findKeywordIndex(tc.query, "DELETE") if deleteIdx <= 0 { t.Errorf("DELETE keyword not found in: %s", tc.query) } // Verify it's the correct DELETE (the operation, not string content) // by checking it appears after the closing paren closeParenIdx := strings.LastIndex(tc.query, ")") if deleteIdx < closeParenIdx { t.Errorf("DELETE found too early (idx=%d, closeParen=%d) - may be inside string: %s", deleteIdx, closeParenIdx, tc.query) } }) } } // TestExecuteWithoutTransaction_DeleteRouting verifies the exact routing logic func TestExecuteWithoutTransaction_DeleteRouting(t *testing.T) { testCases := []struct { name string query string shouldDelete bool }{ {"simple node delete", "MATCH (n) DELETE n", true}, {"node with label", "MATCH (n:Person) DELETE n", true}, {"relationship delete", "MATCH ()-[r]->() DELETE r", true}, {"detach delete", "MATCH (n) DETACH DELETE n", true}, {"with where", "MATCH (n) WHERE n.x = 1 DELETE n", true}, {"string with delete", "MATCH (n {x: 'DELETE'}) DELETE n", true}, } for _, tc := range testCases { t.Run(tc.name, func(t *testing.T) { hasDelete := findKeywordIndex(tc.query, "DELETE") > 0 hasDetachDelete := containsKeywordOutsideStrings(tc.query, "DETACH DELETE") wouldRouteToDelete := hasDelete || hasDetachDelete if wouldRouteToDelete != tc.shouldDelete { t.Errorf("Routing mismatch for %q: got wouldRouteToDelete=%v, want %v", tc.query, wouldRouteToDelete, tc.shouldDelete) } }) } }