StockSpark MCP Server

# MCP Tool Simplification Guide ## 🎯 **Simplified Image Upload Approach** The StockSpark MCP server now uses a **unified image upload method** that handles all image types automatically, eliminating the need for complex tool prioritization. ## 🔄 **Single Upload Tool: `upload_vehicle_images`** ### **Supports All Input Types** ```javascript // ✅ Handles everything automatically • File paths: "/path/to/image.jpg" • URLs: "https://example.com/image.jpg" • Claude UI pasted images: Auto-saved to temp files first ``` ### **Automatic Processing Flow** ``` Claude UI Images → Temp Files → Path-based Upload → Cleanup File Paths/URLs → Direct Upload ``` ## ✅ **Benefits of Simplification** ### **1. No Tool Selection Confusion** - **Before**: 3 different upload tools with complex priority rules - **After**: 1 unified tool handles everything ### **2. Automatic Optimization** - Claude UI images still get filesystem optimization - No manual tool selection required - Same performance benefits maintained ### **3. Cleaner Code** - Removed `image-tool-priorities.js` (217 lines) - Removed `uploadImageFromBase64` method (106 lines) - Removed `uploadImagesFromData` method (74 lines) - Removed 2 redundant upload handlers (180 lines) ### **4. Enhanced Logging** - All image operations fully logged - Temp file creation/cleanup tracked - Clear distinction between input types ## 🏗️ **Implementation Details** ### **Input Processing** ```javascript for (const image of images) { if (typeof image === 'string') { // File path or URL - use directly processedImages.push(image); } else if (image?.type === 'image' && image.source) { // Claude UI image - save to temp file first const tempPath = await saveClaudeImageToTempFile( image.source.data, image.source.media_type, filename ); processedImages.push(tempPath); tempFilesToCleanup.push(tempPath); } } ``` ### **Automatic Cleanup** ```javascript // Always cleanup temp files in finally block if (tempFilesToCleanup.length > 0) { await cleanupTempFiles(tempFilesToCleanup); logger.info(`Cleaned up ${tempFilesToCleanup.length} temporary files`); } ``` ## 📊 **Performance Maintained** ### **Upload Speed Comparison** - **Claude UI images**: Still optimized via temp files (1-2 seconds) - **File paths**: Direct upload (2-5 seconds) - **URLs**: Download then upload (3-8 seconds) ### **Code Complexity Reduction** - **Before**: 577 lines of image upload code - **After**: 327 lines of image upload code - **Reduction**: 43% less code to maintain ## 🎯 **User Experience** ### **For AI Agents** ```javascript // Simple usage - no tool selection needed upload_vehicle_images({ vehicleId: 123, images: [ "/path/to/image1.jpg", "https://example.com/image2.jpg", { type: "image", source: { ... } } // Pasted image ], mainImageIndex: 0 }); ``` ### **For Developers** - Single upload method to understand and maintain - Consistent error handling and logging - Automatic temp file management - Clear separation of concerns ## 🧹 **Cleanup Completed** ### **Files Removed** - `src/tools/image-tool-priorities.js` ### **Methods Removed** - `uploadImageFromBase64()` - `uploadImagesFromData()` - `processClaudeImages()` - `saveImagesToTempFiles()` - `validateImageUrl()` ### **Handlers Removed** - `upload_vehicle_images_claude` - `upload_vehicle_images_from_data` ### **Documentation Updated** - Updated tool descriptions - Removed priority references - Simplified usage examples This simplification maintains all performance benefits while significantly reducing complexity and maintenance overhead!