"""
Tests for CLI backends module.
Tests the AgentCLI protocol and its implementations (Claude, Codex).
"""
import os
from unittest.mock import patch
import pytest
from claude_team_mcp.cli_backends import (
AgentCLI,
ClaudeCLI,
CodexCLI,
claude_cli,
codex_cli,
get_cli_backend,
)
class TestAgentCLIProtocol:
"""Tests for the AgentCLI protocol."""
def test_claude_cli_is_agent_cli(self):
"""ClaudeCLI should be an instance of AgentCLI protocol."""
assert isinstance(claude_cli, AgentCLI)
def test_codex_cli_is_agent_cli(self):
"""CodexCLI should be an instance of AgentCLI protocol."""
assert isinstance(codex_cli, AgentCLI)
class TestClaudeCLI:
"""Tests for Claude CLI backend."""
def test_engine_id(self):
"""Engine ID should be 'claude'."""
cli = ClaudeCLI()
assert cli.engine_id == "claude"
def test_command_default(self):
"""Default command should be 'claude'."""
with patch.dict(os.environ, {}, clear=True):
# Clear CLAUDE_TEAM_COMMAND if set
os.environ.pop("CLAUDE_TEAM_COMMAND", None)
cli = ClaudeCLI()
assert cli.command() == "claude"
def test_command_from_env(self):
"""Command should respect CLAUDE_TEAM_COMMAND env var."""
with patch.dict(os.environ, {"CLAUDE_TEAM_COMMAND": "happy"}):
cli = ClaudeCLI()
assert cli.command() == "happy"
def test_build_args_empty_default(self):
"""Default args should be empty list."""
cli = ClaudeCLI()
args = cli.build_args()
assert args == []
def test_build_args_skip_permissions(self):
"""Should add --dangerously-skip-permissions flag."""
cli = ClaudeCLI()
args = cli.build_args(dangerously_skip_permissions=True)
assert "--dangerously-skip-permissions" in args
def test_build_args_settings_file_default_command(self):
"""Should add --settings flag for default claude command."""
with patch.dict(os.environ, {}, clear=True):
os.environ.pop("CLAUDE_TEAM_COMMAND", None)
cli = ClaudeCLI()
args = cli.build_args(settings_file="/path/to/settings.json")
assert "--settings" in args
assert "/path/to/settings.json" in args
def test_build_args_settings_file_skipped_for_custom_command(self):
"""Should NOT add --settings flag for custom commands like 'happy'."""
with patch.dict(os.environ, {"CLAUDE_TEAM_COMMAND": "happy"}):
cli = ClaudeCLI()
args = cli.build_args(settings_file="/path/to/settings.json")
assert "--settings" not in args
def test_ready_patterns_not_empty(self):
"""Ready patterns should not be empty."""
cli = ClaudeCLI()
patterns = cli.ready_patterns()
assert len(patterns) > 0
def test_ready_patterns_includes_prompt(self):
"""Ready patterns should include the '>' prompt."""
cli = ClaudeCLI()
patterns = cli.ready_patterns()
assert ">" in patterns
def test_idle_detection_method(self):
"""Idle detection should use stop_hook."""
cli = ClaudeCLI()
assert cli.idle_detection_method() == "stop_hook"
def test_supports_settings_file_default_command(self):
"""Should support settings file for default claude command."""
with patch.dict(os.environ, {}, clear=True):
os.environ.pop("CLAUDE_TEAM_COMMAND", None)
cli = ClaudeCLI()
assert cli.supports_settings_file() is True
def test_supports_settings_file_custom_command(self):
"""Should NOT support settings file for custom commands."""
with patch.dict(os.environ, {"CLAUDE_TEAM_COMMAND": "happy"}):
cli = ClaudeCLI()
assert cli.supports_settings_file() is False
def test_build_full_command_simple(self):
"""build_full_command should combine command and args."""
with patch.dict(os.environ, {}, clear=True):
os.environ.pop("CLAUDE_TEAM_COMMAND", None)
cli = ClaudeCLI()
cmd = cli.build_full_command(dangerously_skip_permissions=True)
assert cmd == "claude --dangerously-skip-permissions"
def test_build_full_command_with_env_vars(self):
"""build_full_command should prepend env vars."""
with patch.dict(os.environ, {}, clear=True):
os.environ.pop("CLAUDE_TEAM_COMMAND", None)
cli = ClaudeCLI()
cmd = cli.build_full_command(env_vars={"FOO": "bar", "BAZ": "qux"})
assert "FOO=bar" in cmd
assert "BAZ=qux" in cmd
assert cmd.endswith("claude")
class TestCodexCLI:
"""Tests for Codex CLI backend."""
def test_engine_id(self):
"""Engine ID should be 'codex'."""
cli = CodexCLI()
assert cli.engine_id == "codex"
def test_command_default(self):
"""Default command should be 'codex'."""
with patch.dict(os.environ, {}, clear=True):
# Clear CLAUDE_TEAM_CODEX_COMMAND if set
os.environ.pop("CLAUDE_TEAM_CODEX_COMMAND", None)
cli = CodexCLI()
assert cli.command() == "codex"
def test_command_from_env(self):
"""Command should respect CLAUDE_TEAM_CODEX_COMMAND env var."""
with patch.dict(os.environ, {"CLAUDE_TEAM_CODEX_COMMAND": "happy codex"}):
cli = CodexCLI()
assert cli.command() == "happy codex"
def test_build_args_empty_default(self):
"""Default args should be empty list."""
cli = CodexCLI()
args = cli.build_args()
assert args == []
def test_build_args_skip_permissions_maps_to_full_auto(self):
"""skip_permissions should map to --full-auto for Codex."""
cli = CodexCLI()
args = cli.build_args(dangerously_skip_permissions=True)
assert "--full-auto" in args
def test_build_args_settings_file_ignored(self):
"""Settings file should be ignored (Codex doesn't support it)."""
cli = CodexCLI()
args = cli.build_args(settings_file="/path/to/settings.json")
assert "--settings" not in args
assert "/path/to/settings.json" not in args
def test_ready_patterns_not_empty(self):
"""Ready patterns should not be empty."""
cli = CodexCLI()
patterns = cli.ready_patterns()
assert len(patterns) > 0
def test_idle_detection_method(self):
"""Idle detection should use JSONL streaming (captures output via tee)."""
cli = CodexCLI()
assert cli.idle_detection_method() == "jsonl_stream"
def test_supports_settings_file(self):
"""Codex should NOT support settings file."""
cli = CodexCLI()
assert cli.supports_settings_file() is False
def test_build_full_command_simple(self):
"""build_full_command should return just 'codex' for defaults."""
with patch.dict(os.environ, {}, clear=True):
os.environ.pop("CLAUDE_TEAM_CODEX_COMMAND", None)
cli = CodexCLI()
cmd = cli.build_full_command()
assert cmd == "codex"
def test_build_full_command_with_full_auto(self):
"""build_full_command should add --full-auto."""
with patch.dict(os.environ, {}, clear=True):
os.environ.pop("CLAUDE_TEAM_CODEX_COMMAND", None)
cli = CodexCLI()
cmd = cli.build_full_command(dangerously_skip_permissions=True)
assert cmd == "codex --full-auto"
def test_build_full_command_with_env_var(self):
"""build_full_command should use CLAUDE_TEAM_CODEX_COMMAND."""
with patch.dict(os.environ, {"CLAUDE_TEAM_CODEX_COMMAND": "happy codex"}):
cli = CodexCLI()
cmd = cli.build_full_command(dangerously_skip_permissions=True)
assert cmd == "happy codex --full-auto"
class TestGetCliBackend:
"""Tests for the get_cli_backend factory function."""
def test_get_claude_backend(self):
"""Should return ClaudeCLI for 'claude'."""
cli = get_cli_backend("claude")
assert isinstance(cli, ClaudeCLI)
def test_get_codex_backend(self):
"""Should return CodexCLI for 'codex'."""
cli = get_cli_backend("codex")
assert isinstance(cli, CodexCLI)
def test_get_unknown_backend_raises(self):
"""Should raise ValueError for unknown agent type."""
with pytest.raises(ValueError) as exc_info:
get_cli_backend("unknown_agent")
assert "Unknown agent type" in str(exc_info.value)
assert "unknown_agent" in str(exc_info.value)
def test_get_backend_default_is_claude(self):
"""Default agent type should be 'claude'."""
cli = get_cli_backend()
assert isinstance(cli, ClaudeCLI)
