DollhouseMCP

# Session Notes - September 29, 2025 Late Evening **Time**: 9:20 PM **Duration**: ~2 hours **Focus**: SonarQube MCP integration testing and memory system debugging ## Summary Tested SonarQube MCP server integration, discovered malformed memory files blocking Sonar Guardian activation, identified ElementFormatter needs security scanner fix. Created urgent Issue #1211 for tomorrow morning. ## Work Completed ### 1. SonarQube MCP Server Testing ✅ **Tested SonarQube Integration**: - System Status: UP (v8.0.0.67857) - Projects: 4 DollhouseMCP projects tracked - mcp-server metrics: 11 bugs, 2,660 code smells, 0 vulnerabilities **Found 11 "Bugs" - All in Test Files**: - 5 useless object instantiations (Template.test.ts, RateLimiterSecurity.test.ts) - 2 regex patterns matching empty strings (regexValidator.test.ts) - 4 control characters in regex (path-traversal.test.ts, yaml-deserialization.test.ts) **Analysis**: All are test code quality issues, not runtime bugs. Tests are intentionally testing edge cases and error conditions. ### 2. Sonar Guardian Suite Loading ✅ **Successfully Activated**: - ✅ sonar-guardian (persona) - ✅ sonarcloud-modernizer (skill) - ✅ sonar-sweep-agent (agent) - ✅ sonarcloud-fix-template (template) **Failed to Load**: - ❌ sonarcloud-rules-reference (memory) - ❌ sonarcloud-api-reference (memory) ### 3. Memory System Debugging 🔍 **Root Cause Identified**: Both memory files have **embedded YAML frontmatter inside content**: ```yaml entries: - content: >- --- version: 1.0.0 # ← Should be in metadata, not content tags: - sonarcloud --- # Actual content starts here... ``` **Problems**: 1. YAML frontmatter embedded in content field (lines 3-13) 2. Duplicate metadata in proper location 3. Content stored as single folded line (unreadable) 4. Should start with `# SonarCloud Rules Reference`, not frontmatter **Files Affected**: - `~/.dollhouse/portfolio/memories/2025-09-28/sonarcloud-rules-reference.yaml` - `~/.dollhouse/portfolio/memories/2025-09-27/sonarcloud-api-reference.yaml` ### 4. ElementFormatter Discovery 🛠️ **Found the Fix Tool**: - Location: `src/utils/ElementFormatter.ts` - Created: PR #1193 (merged today) - Purpose: Fixes malformed elements by: 1. Unescaping newline characters 2. **Extracting embedded metadata to proper YAML structure** 3. Formatting YAML for readability **CLI Tool Exists**: `src/cli/format-element.ts` ```bash node dist/cli/format-element.js <file> --in-place ``` **BUT - Critical Bug Discovered**: ElementFormatter uses `validateContent: true` in 5 locations, hitting security scanner false positives on legitimate content. ### 5. Issue Created: #1211 (URGENT) 🚨 **Title**: fix(formatter): ElementFormatter hits security scanner false positives - needs validateContent: false **Priority**: Critical - Fix tomorrow morning (interview at 11 AM) **Fix Required**: Change `validateContent: true` → `validateContent: false` in 5 locations: - Line 178 (formatContent validation) - Line 402 (parseMemoryContent) - Line 531 (extractMetadata - markdown) - Line 605 (extractMetadata - content block) - Line 622 (extractMetadata - fallback) **Time Estimate**: 15 minutes (find/replace + test) **Context**: PR #1207 fixed this in MemoryManager.ts. ElementFormatter was created in PR #1193 before that fix. ### 6. Process Improvement: GitHub Labels ✅ **Problem**: Created issue with non-existent labels (`urgent`, `priority`) causing failed attempts. **Solution Added to CLAUDE.md**: ```markdown ## Creating GitHub Issues **ALWAYS check available labels before creating issues:** ```bash gh label list --limit 100 --json name --jq '.[].name' ``` **Rules:** 1. **NEVER guess or assume labels exist** - Always check first 2. **Only use labels from the list above** - No made-up labels 3. **Check once, create once** - Get it right the first time 4. **Pattern**: Check labels → Use only what exists → Create issue ``` **Location**: CLAUDE.md lines 191-205 ## Key Files Modified 1. `CLAUDE.md` - Added GitHub issue creation guidelines (lines 191-205) 2. Updated version to v1.9.13 and date to September 30, 2025 ## Issues Created - **#1211** - fix(formatter): ElementFormatter hits security scanner false positives - Labels: `bug`, `priority: critical`, `security`, `area: tooling` - Assignee: @me - Priority: URGENT - fix tomorrow morning before 11 AM interview ## Key Learnings ### Technical 1. **ElementFormatter vs Migration Tool**: - Migration tool: Converts .md → .yaml for legacy files - ElementFormatter: Fixes malformed YAML (embedded frontmatter, readability) - Both exist, different purposes 2. **validateContent Flag**: - `true`: Full security scanning (word matching, patterns) - `false`: Local files are pre-trusted - MemoryManager: Fixed in PR #1207 - ElementFormatter: Still needs fix (Issue #1211) 3. **Memory Loading**: - Scans date-based subdirectories only (e.g., `2025-09-28/`) - Does NOT scan root memories directory - Files in wrong location won't load ### Process 1. **Always check available options before using them** (labels, commands, etc.) 2. **SonarQube test "bugs" are test quality issues** - not production problems 3. **Memory system has two repair mechanisms**: - Auto-repair on load (timestamp fixes) - Manual ElementFormatter (structural fixes) ## Next Session Priorities ### Priority 1: Fix ElementFormatter (URGENT - Morning) 1. Checkout feature branch 2. Change 5 instances of `validateContent: true` to `false` 3. Test on sonarcloud-rules-reference.yaml 4. Test on sonarcloud-api-reference.yaml 5. Create PR **Deadline**: Before 11 AM (interview scheduled) ### Priority 2: Verify Sonar Guardian 1. After ElementFormatter fix, format both sonarcloud memory files 2. Reload memories 3. Verify sonarcloud-rules-reference and sonarcloud-api-reference activate 4. Test Sonar Guardian with full suite ### Priority 3: SonarQube Test File "Bugs" - Document that these are intentional test patterns - Consider adding comments to tests explaining why patterns are needed - Low priority - not blocking anything ## Context for Tomorrow **Morning Workflow**: 1. Start early (before 11 AM interview) 2. Fix Issue #1211 (15 minutes) 3. Test ElementFormatter on sonarcloud files 4. Format and reload memories 5. Verify Sonar Guardian fully operational **Files to Format**: ```bash node dist/cli/format-element.js ~/.dollhouse/portfolio/memories/2025-09-28/sonarcloud-rules-reference.yaml --in-place node dist/cli/format-element.js ~/.dollhouse/portfolio/memories/2025-09-27/sonarcloud-api-reference.yaml --in-place ``` **After Fix**: ```bash mcp__dollhousemcp-production__reload_elements --type memories mcp__dollhousemcp-production__activate_element --name sonarcloud-rules-reference --type memories mcp__dollhousemcp-production__activate_element --name sonarcloud-api-reference --type memories ``` ## Statistics - **Issues Created**: 1 (#1211) - **Files Modified**: 1 (CLAUDE.md) - **Tools Tested**: SonarQube MCP, ElementFormatter - **Elements Activated**: 4 (sonar-guardian suite) - **PRs Referenced**: #1193, #1207, #1210, #1209 - **Session Duration**: ~2 hours - **Context Used**: ~108k/200k tokens (54%) ## Mick's Feedback "What is it going to take to train you to create issues with only the tags and labels and titles and other information that is available to you and not to add anything else?" **Response**: Added mandatory label checking to CLAUDE.md. Pattern: Check available options → Use only what exists → Execute once. --- **Session ended**: 9:20 PM **Status**: Issue created, ready for morning fix **Next session**: Early morning before 11 AM interview